Page 1 of 1

Trojan virus perk not working anymore

Posted: Fri Feb 10, 2017 8:49 pm
by Hazelnut
Hi, i have the Trojan virus perk on 3 of my specialists because I use haywire a lot, so it's great to have. First few times it worked but now I've had three missions where it's not done any damage at all. This last time hack was 63% to control (IIRC) so should have done some damage at least. I think it's become broken, don't get any messages or see any damage.

Since my MSGT specialist got full override skill it hasn't worked, but that may just be a co-incidence. So, should I respec into other perks, investigate by going back to old saves - or is there a fix to this?

Re: Trojan virus perk not working anymore

Posted: Sun Feb 12, 2017 4:19 pm
by Hazelnut
This bug just meant my best gunner was crit and took 9 damage from superheavy mec that was hacked. At the end of turn it moved and shot her. Supposed to have no actions and take 0-8 damage. Twenty days she's out of action and I really needed her for the invasion that just happened.

Please could this be fixed for 1.2? It's a brilliant perk for my hackers but not if it doesn't work.

Re: Trojan virus perk not working anymore

Posted: Sun Feb 12, 2017 8:14 pm
by Amineri
Hazelnut wrote:Hi, i have the Trojan virus perk on 3 of my specialists because I use haywire a lot, so it's great to have. First few times it worked but now I've had three missions where it's not done any damage at all. This last time hack was 63% to control (IIRC) so should have done some damage at least. I think it's become broken, don't get any messages or see any damage.

Since my MSGT specialist got full override skill it hasn't worked, but that may just be a co-incidence. So, should I respec into other perks, investigate by going back to old saves - or is there a fix to this?
I had a look again at Trojan Virus (it was released with PerkPack, and it's been a while since I'd looked at it), and I don't see anything obvious in the code that would conflict with Full Override. I haven't really changed much about the ability since I initially finished the code last March, as we haven't gotten any reports of it failing in this manner.

If you can provide a savefile that reproduces this issue, I'd definitely like to take a look at it.

Re: Trojan virus perk not working anymore

Posted: Mon Feb 13, 2017 1:06 pm
by Hazelnut
I will try to gather one for you tonight. I got the trojan virus message for the first time in ages last night. For a MEC I had shot to death the turn before (basically assuming trojan would not fire) so that's weird.

I think this is likely to be some subtle interaction of stuff. Can you point me in the direction of the code for this perk? I might do some digging myself. (middle aged programmer here, but know v. little about xcom / unreal)

Thanks.

Re: Trojan virus perk not working anymore

Posted: Mon Feb 13, 2017 11:04 pm
by Hazelnut
Amineri wrote:If you can provide a savefile that reproduces this issue, I'd definitely like to take a look at it.
Okay, spent an hour or so finding a save from a mission where I could recall it happening. hacked a mec and went through a few turns killing everything else. The save has the mec and specialist that hacked it with actions left, so you can see that the haywire button says T-1 i.e. the mec is about to revert to advent control. Whatever i do with it, Trojan doesn't fire. You can see the specialist has the perk.

Sorry that a couple of pods come barrelling in at the end of turn, it does rather slow down getting to see the mec shoot one of my troops.

Unfortunately the forums will not let me add the savefile as an attachment - it's too big at 3.5Mb zipped. How would you like me to send it to you?

Re: Trojan virus perk not working anymore

Posted: Tue Feb 14, 2017 3:43 pm
by Hazelnut
It's worked on the last 2 missions, no idea what is going on with it. Please let me know how to get the savefile to you.

Re: Trojan virus perk not working anymore

Posted: Thu Feb 16, 2017 10:38 am
by Hazelnut
And it failed last night again, got 22 days in infirmary from that. Next mission I shoot the MEC dead before it turns just like I used to and the trojan virus message popped up for the dead MEC! So it's too unreliable to use for me at the moment. I now have 2 savefiles where it fails.

Re: Trojan virus perk not working anymore

Posted: Thu Feb 16, 2017 1:57 pm
by archangel
I had this bug happen exactly one time I left MEC live long enough for haywire to wear off. I hacked the MEC so it shuts down and sent a sninobi with bladestorm next to it. The plan was to have shinobi get that attack off if haywire does not do enough damage. Haywire says enemy loses one action and receives damage so I planned on MEC either shooting shinobi which would activate bladestorm or just moving away.
But haywire didn't activate, MEC didn't receive any damage but luckily Shinobi killed him anyways.

Since that was first time I experienced haywire I assumed it only works if you take control of MECS and not just shut them down but now that I see this topic, I probably ran into a bug as well.
Hopefully you can fix it at some time.

Re: Trojan virus perk not working anymore

Posted: Thu Feb 16, 2017 4:28 pm
by Hazelnut
Glad it's not just me. :)

I take control 9/10 times, now I have high level hackers I see MECs as free shields. :lol:

Re: Trojan virus perk not working anymore

Posted: Sat Feb 18, 2017 1:09 pm
by tardy
Bump, worth looking into as this has happened to me as well on multiple occasions.

Re: Trojan virus perk not working anymore

Posted: Sat Feb 18, 2017 7:15 pm
by tracktwo
We're still looking into it but we will need a save. The best way to get a save that's too big to upload to the forum is to send us a link to a dropbox/google drive/onedrive/whatever file.

Re: Trojan virus perk not working anymore

Posted: Sun Feb 19, 2017 4:13 pm
by Hazelnut
tracktwo wrote:We're still looking into it but we will need a save. The best way to get a save that's too big to upload to the forum is to send us a link to a dropbox/google drive/onedrive/whatever file.
Ok will try to do this today.

Re: Trojan virus perk not working anymore

Posted: Sun Feb 19, 2017 8:15 pm
by Ithuriel
Tbh I've had the perk work perfectly well for me the last few times I used it, though it has been a week or two; are you sure it's not due to a mod conflict or something? (okay tbh I didn't *see* it work but I later found out the drone was dead, so...)

Re: Trojan virus perk not working anymore

Posted: Tue Feb 21, 2017 10:38 pm
by Undershaft
I experienced the same bug. Took control of a drone, it got fired at and was left with two health and one armor. When the hack ended, it lost its turn, but didn't receive any damage. Playing on ironman, though, so I have no savefile to offer.

Re: Trojan virus perk not working anymore

Posted: Thu Feb 23, 2017 1:09 pm
by Hazelnut
Sorry for the delay uploading the savefile. Had a family thing to deal with.

https://drive.google.com/file/d/0B4A9Js ... sp=sharing

The MEC and specialist who hacked it have actions so you can see. I've had it work many times since then, and fail a few as well. I've not been able to discern a pattern yet.

I have another if you need it let me know. It's not set up as nice.

Re: Trojan virus perk not working anymore

Posted: Mon Feb 27, 2017 6:17 pm
by Canderous
Having the same problem which cost me a soldier's life :(

Re: Trojan virus perk not working anymore

Posted: Mon Feb 27, 2017 9:10 pm
by Hazelnut
Just wanted to report that Trojan is unreliable in 1.2 as well. (as expected - just confirmation)

Re: Trojan virus perk not working anymore

Posted: Wed Mar 01, 2017 7:09 am
by tracktwo
Thanks for the save. This is a weird one. I can clearly repro your bug with that save: ending the turn the MEC reverts to the Alien team and no Trojan is applied. If I drop a MEC into that save and hack them, trojan does work correctly. Looking in the debug history I can see when I hack the mec the trojan ability is applied correctly, but that is missing from the history when you did the hack. So that explains why it didn't work: trojan didn't get applied. Unfortunately I don't know *why* it wasn't applied, since it works correctly for me!

One thing that may be able to help, if you're willing to help out a bit more in tracking this down: Can you go into your XComLW_PerkPack.ini file and find the line that says:

+SUPPRESS=PPTrace

Comment it out (with a semicolon, like the PPDebug line above it), relaunch the game, hack a MEC, immediately save the game, and send me both the save file and the Launch.log file from your Documents\My Games\XCOM2\XComGame\Logs folder? The log file may help a lot in figuring out why it isn't applying trojan on the hack. I'll keep trying to repro it on my end in the meantime.

Re: Trojan virus perk not working anymore

Posted: Thu Mar 02, 2017 12:11 am
by tracktwo
Ok, I found the bug.

First of all, thanks for a save with minimal mods installed. This actually helped a *ton*, because it meant I could use the replay feature of the game to walk back and forth through your mission. I can almost never use this, because it crashes when my modlist doesn't match the modlist from the save.

So the bug is: Trojan is set to require visibility to proc, but haywire doesn't. If you haywire from squadsight range, you'll get control but Trojan won't proc. I can get a fix for this into 1.3.

Re: Trojan virus perk not working anymore

Posted: Thu Mar 02, 2017 1:58 am
by steave
tracktwo wrote:Ok, I found the bug.

First of all, thanks for a save with minimal mods installed. This actually helped a *ton*, because it meant I could use the replay feature of the game to walk back and forth through your mission. I can almost never use this, because it crashes when my modlist doesn't match the modlist from the save.

So the bug is: Trojan is set to require visibility to proc, but haywire doesn't. If you haywire from squadsight range, you'll get control but Trojan won't proc. I can get a fix for this into 1.3.
Awesome, thanks. Might actually be able to justify taking it again :)

Re: Trojan virus perk not working anymore

Posted: Fri Mar 03, 2017 1:33 pm
by Hazelnut
tracktwo wrote:Ok, I found the bug.

First of all, thanks for a save with minimal mods installed. This actually helped a *ton*, because it meant I could use the replay feature of the game to walk back and forth through your mission. I can almost never use this, because it crashes when my modlist doesn't match the modlist from the save.

So the bug is: Trojan is set to require visibility to proc, but haywire doesn't. If you haywire from squadsight range, you'll get control but Trojan won't proc. I can get a fix for this into 1.3.
No problem, I use minimal mods TBH. Sorry for not responding to your request for help. The family thing I've been dealing with was my mum passing so not really been sociable recently.

Great work finding the issue, that would explain the 'unreliability' of Trojan! :D

Re: Trojan virus perk not working anymore

Posted: Sat Mar 04, 2017 2:33 am
by tracktwo
Sorry about your mother and no problem about the request. Getting me the save turned out to be plenty!