Page 1 of 1

AWC perk selection bugs

Posted: Sat Jan 28, 2017 2:15 am
by gftgy
TL;DR Many of the perks aren't being assigned in the AWC. To fix, replace lines 180-255 in the XComLW_AWCPack.ini with the following.

Code: Select all

;;; Restrictions ;;;

; unit cannot get AWCAbility if it is of type RestrictedClass
+AWCRestrictions=(AWCAbility="WalkFire", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="WalkFire", RestrictedAbility="StunGunner")
+AWCRestrictions=(AWCAbility="RapidFire", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="Holotargeting", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="Holotargeting", RestrictedAbility="StunGunner")
+AWCRestrictions=(AWCAbility="CloseCombatSpecialist", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="CloseCombatSpecialist", RestrictedAbility="KnifeFighter")
+AWCRestrictions=(AWCAbility="Shadowstep", RestrictedAbility="StunGunner")
+AWCRestrictions=(AWCAbility="LightningReflexes_LW", RestrictedAbility="Slash_LW")
+AWCRestrictions=(AWCAbility="Phantom", RestrictedAbility="ThreatAssessment")
+AWCRestrictions=(AWCAbility="Suppression_LW", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="Suppression_LW", RestrictedAbility="StunGunner")
+AWCRestrictions=(AWCAbility="TraverseFire", RestrictedAbility="PointBlank")
+AWCRestrictions=(AWCAbility="TraverseFire", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="PrecisionShot", RestrictedAbility="StunGunner")
+AWCRestrictions=(AWCAbility="PrecisionShot", RestrictedAbility="KnifeFighter")
+AWCRestrictions=(AWCAbility="Flush", RestrictedAbility="FireandSteel")
+AWCRestrictions=(AWCAbility="CloseandPersonal", RestrictedAbility="KnifeFighter")
+AWCRestrictions=(AWCAbility="CloseandPersonal", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="Stealth", RestrictedAbility="ThreatAssessment")
+AWCRestrictions=(AWCAbility="Stealth", RestrictedAbility="KnifeFighter")
+AWCRestrictions=(AWCAbility="HailofBullets", RestrictedAbility="StunGunner")
+AWCRestrictions=(AWCAbility="HailofBullets", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="IronCurtain", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="IronCurtain", RestrictedAbility="StunGunner")
+AWCRestrictions=(AWCAbility="CyclicFire", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="CyclicFire", RestrictedAbility="StunGunner")
+AWCRestrictions=(AWCAbility="EverVigilant", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="Infighter", RestrictedAbility="Holotarget")

+AWCRestrictions=(AWCAbility="Cutthroat", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="Cutthroat", RestrictedAbility="StunGunner")
+AWCRestrictions=(AWCAbility="Cutthroat", RestrictedAbility="ThreatAssessment")
+AWCRestrictions=(AWCAbility="Cutthroat", RestrictedAbility="PointBlank")
+AWCRestrictions=(AWCAbility="Cutthroat", RestrictedAbility="HeavyOrdnance_LW")
+AWCRestrictions=(AWCAbility="Cutthroat", RestrictedAbility="FireandSteel")
+AWCRestrictions=(AWCAbility="Cutthroat", RestrictedAbility="FireandSteel")
+AWCRestrictions=(AWCAbility="Cutthroat", RestrictedAbility="VoidRift")
+AWCRestrictions=(AWCAbility="Blademaster", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="Blademaster", RestrictedAbility="StunGunner")
+AWCRestrictions=(AWCAbility="Blademaster", RestrictedAbility="ThreatAssessment")
+AWCRestrictions=(AWCAbility="Blademaster", RestrictedAbility="PointBlank")
+AWCRestrictions=(AWCAbility="Blademaster", RestrictedAbility="HeavyOrdnance_LW")
+AWCRestrictions=(AWCAbility="Blademaster", RestrictedAbility="FireandSteel")
+AWCRestrictions=(AWCAbility="Blademaster", RestrictedAbility="VoidRift")
+AWCRestrictions=(AWCAbility="Reaper", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="Reaper", RestrictedAbility="StunGunner")
+AWCRestrictions=(AWCAbility="Reaper", RestrictedAbility="ThreatAssessment")
+AWCRestrictions=(AWCAbility="Reaper", RestrictedAbility="PointBlank")
+AWCRestrictions=(AWCAbility="Reaper", RestrictedAbility="HeavyOrdnance_LW")
+AWCRestrictions=(AWCAbility="Reaper", RestrictedAbility="FireandSteel")
+AWCRestrictions=(AWCAbility="Reaper", RestrictedAbility="VoidRift")
+AWCRestrictions=(AWCAbility="SwordSlice_LW", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="SwordSlice_LW", RestrictedAbility="StunGunner")
+AWCRestrictions=(AWCAbility="SwordSlice_LW", RestrictedAbility="ThreatAssessment")
+AWCRestrictions=(AWCAbility="SwordSlice_LW", RestrictedAbility="PointBlank")
+AWCRestrictions=(AWCAbility="SwordSlice_LW", RestrictedAbility="HeavyOrdnance_LW")
+AWCRestrictions=(AWCAbility="SwordSlice_LW", RestrictedAbility="FireandSteel")
+AWCRestrictions=(AWCAbility="SwordSlice_LW", RestrictedAbility="VoidRift")
+AWCRestrictions=(AWCAbility="Combatives", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="Combatives", RestrictedAbility="StunGunner")
+AWCRestrictions=(AWCAbility="Combatives", RestrictedAbility="ThreatAssessment")
+AWCRestrictions=(AWCAbility="Combatives", RestrictedAbility="PointBlank")
+AWCRestrictions=(AWCAbility="Combatives", RestrictedAbility="HeavyOrdnance_LW")
+AWCRestrictions=(AWCAbility="Combatives", RestrictedAbility="FireandSteel")
+AWCRestrictions=(AWCAbility="Combatives", RestrictedAbility="VoidRift")
+AWCRestrictions=(AWCAbility="Bladestorm", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="Bladestorm", RestrictedAbility="StunGunner")
+AWCRestrictions=(AWCAbility="Bladestorm", RestrictedAbility="ThreatAssessment")
+AWCRestrictions=(AWCAbility="Bladestorm", RestrictedAbility="PointBlank")
+AWCRestrictions=(AWCAbility="Bladestorm", RestrictedAbility="HeavyOrdnance_LW")
+AWCRestrictions=(AWCAbility="Bladestorm", RestrictedAbility="FireandSteel")
+AWCRestrictions=(AWCAbility="Bladestorm", RestrictedAbility="VoidRift")
V1.1 UPDATE:

The good:
Soldiers no longer seem to have an AWC skill selected twice.
Skills no longer seem to be "cooked" for either inclusion or exclusion. Commenting out a +AWCAbilityTree line properly excludes that ability from selection. Skills that previously refused to be placed like Phantom or Lightning Reflexes may now be selected if the restrictedclass flag is removed.

The bad:
RestrictedClass= set for one class STILL removes the ability from selection for ALL classes.

An easy hotfix for this is to replace all of the RestrictedClass lines with RestrictedAbility. The following Find and Replace functions worked for me and and cause no conflicts:
[ RestrictedClass="LWS_Technical" ] F&R [ RestrictedAbility="FireandSteel" ]
[ RestrictedClass="LWS_Ranger" ] F&R [ RestrictedAbility="PointBlank" ]
[ RestrictedClass="LWS_Gunner" ] F&R [ RestrictedAbility="KnifeFighter" ]
[ RestrictedClass="LWS_Specialist" ] F&R [ RestrictedAbility="ThreatAssessment" ]
[ RestrictedClass="LWS_Shinobi" ] F&R [ RestrictedAbility="Slash_LW" ]
[ RestrictedClass="LWS_Sharpshooter" ] F&R [ RestrictedAbility="Holotarget" ]
[ RestrictedClass="LWS_Assault" ] F&R [ RestrictedAbility="StunGunner" ]
[ RestrictedClass="LWS_Grenadier" ] F&R [ RestrictedAbility="HeavyOrdnance_LW" ]
[ RestrictedClass="PsiOperative" ] F&R [ RestrictedAbility="VoidRift" ]


ORIGINAL POST BELOW:

Copying my post from the 1.1 changelog for redundancy:

I've been playing around a lot with the AWC. Some things I've noticed:
The AWC generates all of the perks to learn simultaneously. This means that a soldier might get multiple instances of the same pistol perk, while excluding others. Making an .ini adjustment +AWCRestrictions=(AWCAbility="Gunslinger", RestrictedAbility="Gunslinger") [for example] doesn't work either, as despite what the comment on AWCRestrictions says, since the AWC abilities are all generated simultaneously, making a restricted ability will only have an impact if it is pre-existing on the soldier's class list.

Therefore
johnnylump wrote:- Added a bunch of AWC perks to each level, lots of doubling up and a few (Combat Fitness, Lone Wolf, Damn Good Ground) that cross offense and defense
If I'm reading this correctly, you plan on filling all 7 ranks (compared to the 3 ranks you have now), with offensive and defensive perks, many of which will be available at multiple ranks. This means that the available offensive and defensive perks to train will suffer from the same problem as the pistol abilities, "doubling up." When this happens, the soldier will not only lose out on the opportunity of having a more useful perk to train, but will also be forced to train the redundant perk simply to gain access to the next tier. The same issue exists for having the same perks on offensive and defensive lists.

Also regarding the AWC, but perhaps not specifically this patch, is that most of the "AWCAbilityTree..." settings seem to be cooked into the mod, as they are redundant (and therefore persist after changes to) the AWCPack.ini. This means that commenting out most abilities still results in them being selected for the soldier, and a perk added to the tree is half as likely to be selected as one currently on it. (side note: Bombardier seems to be on this "cooked" +AWCAbilityTree_Offense=(Level=2... list, even though it is not in the AWCPACK.ini at that level, meaning in conjunction with the above it can be picked for both levels 2 and 3 of the offensive list.)

Additionally, "RestrictedClass=" seems to filter out an ability from ALL classes, not just the one selected. Since this list also seems to be cooked, removing the section in the .ini still doesn't allow WalkFire, RapidFire, Holotargeting, CloseCombatspecialist, Shadowstep, LightningReflexes_LW, Phantom, Suppression_LW, TraverseFire, PrecisionShot, Flush, CloseandPersonal, Stealth, HailofBullets, IronCurtain, CyclicFire, and EverVigilant. Also Aggression, DoubleTap, and Resilience seem cooked for exclusion, despite not being on a RestrictedClass= in the .ini.
johnnylump wrote:AWC Abilities button in Armory (and foreknowledge of trainable AWC abilities) does not appear until you build AWC
I don't like this change since the AWC is buggy. If I start a game and my soldiers have some messed up AWC perks, I'd rather know immediately upon promotion rather than waiting to complete the AWC. If this is related to training AWC skills from the armory, I would simply disable that change.

It took a lot of testing to narrow this all down. Hope this helps.

Re: AWC perk selection bugs

Posted: Sat Jan 28, 2017 1:05 pm
by Arcalane
I've tweaked my AWC perk tree to be fully revealed, and I don't see a single case of duplication, even amongst the pistol perks.

Here's a selection of seven soldiers; http://imgur.com/a/xM2fZ

You can also see that one of them has Double Tap as a Tier 3 Offense perk, so I'm wondering if this bug is on your end due to mod conflicts?

Re: AWC perk selection bugs

Posted: Sat Jan 28, 2017 10:10 pm
by gftgy
I'm only running a few outfit/voicepack mods. Nothing that would impact skills or gameplay, so I doubt it.

If it is a local issue, it's more likely to be a bug associated with the base game. I can say that I ran these tests ~150 times, so with statistics being the way they are, it's entirely possible that DoubleTap simply didn't come up. (I saw several other low-probability streaks. It's not outside the realm of possibility since I didn't run it a thousand times.)

I did notice that there seemed to be an above-expected number of soldiers not doubling up on the pistol perks. I thought it was statistical unlikelihood, but you may be right that it could be reflecting a bug in the code, rather than the game generating all the AWC skills at once. On the other hand, maybe you got statistically lucky with your soldiers. ;)

Still, the other skills were absolutely, definitively not able to be attributed to soldiers, even if I excluded every other possible ability from selection. I verified the cache, detached mods, reinstalled the game several times before I finally figured out that these must have been "cooked" into the mod. So unless that's been changed in 1.1, that bug, along with most abilities still being selected despite being commented out in the .ini, and restrictedclass= excluding an ability from all classes instead of one, is still around.

Re: AWC perk selection bugs

Posted: Sun Jan 29, 2017 1:40 am
by gftgy
So I've been doing some new testing with 1.1

The good:
Soldiers no longer seem to have an AWC skill selected twice.
Skills no longer seem to be "cooked" for either inclusion or exclusion. Commenting out a +AWCAbilityTree line properly excludes that ability from selection. Skills that previously refused to be placed like Phantom or Lightning Reflexes may now be selected if the restrictedclass flag is removed.

The bad:
RestrictedClass= set for one class STILL removes the ability from selection for ALL classes.

An easy hotfix for this is to replace all of the RestrictedClass lines with RestrictedAbility. The following Find and Replace functions worked for me and and cause no conflicts:
[ RestrictedClass="LWS_Technical" ] F&R [ RestrictedAbility="FireandSteel" ]
[ RestrictedClass="LWS_Ranger" ] F&R [ RestrictedAbility="PointBlank" ]
[ RestrictedClass="LWS_Gunner" ] F&R [ RestrictedAbility="KnifeFighter" ]
[ RestrictedClass="LWS_Specialist" ] F&R [ RestrictedAbility="ThreatAssessment" ]
[ RestrictedClass="LWS_Shinobi" ] F&R [ RestrictedAbility="Slash_LW" ]
[ RestrictedClass="LWS_Sharpshooter" ] F&R [ RestrictedAbility="Holotarget" ]
[ RestrictedClass="LWS_Assault" ] F&R [ RestrictedAbility="StunGunner" ]
[ RestrictedClass="LWS_Grenadier" ] F&R [ RestrictedAbility="HeavyOrdnance_LW" ]
[ RestrictedClass="PsiOperative" ] F&R [ RestrictedAbility="VoidRift" ]

Re: AWC perk selection bugs

Posted: Sun Jan 29, 2017 1:45 am
by gftgy
Any way to summon johnnylump in here? Since this is more-or-less fixed and half of his AWC abilities aren't being called for selection, it's probably worth a hotfix.

Re: AWC perk selection bugs

Posted: Tue Jan 31, 2017 9:11 pm
by gftgy
Johnny? Amineri? Someone?

Re: AWC perk selection bugs

Posted: Tue Jan 31, 2017 10:12 pm
by johnnylump
That's for the research; we confirmed something's wrong with the RestrictedClass setting. It's definitely not worth a hotfix, though; the bug denies you some interesting ability combos but it's not the kind of stability problem or campaign-breaking setting that merits pushing out a fix this instant.

Re: AWC perk selection bugs

Posted: Wed Feb 01, 2017 1:19 am
by gftgy
Glad you're aware. Version control is obviously your prerogative.

Re: AWC perk selection bugs

Posted: Wed Feb 01, 2017 2:16 am
by dodger
Here's some CopyPasta code for those like me who found doing the replacements one by one tedious. No reason for us all to do it. Replaces lines 180-255 in the XComLW_AWCPack.ini

Code: Select all

;;; Restrictions ;;;

; unit cannot get AWCAbility if it is of type RestrictedClass
+AWCRestrictions=(AWCAbility="WalkFire", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="WalkFire", RestrictedAbility="StunGunner")
+AWCRestrictions=(AWCAbility="RapidFire", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="Holotargeting", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="Holotargeting", RestrictedAbility="StunGunner")
+AWCRestrictions=(AWCAbility="CloseCombatSpecialist", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="CloseCombatSpecialist", RestrictedAbility="KnifeFighter")
+AWCRestrictions=(AWCAbility="Shadowstep", RestrictedAbility="StunGunner")
+AWCRestrictions=(AWCAbility="LightningReflexes_LW", RestrictedAbility="Slash_LW")
+AWCRestrictions=(AWCAbility="Phantom", RestrictedAbility="ThreatAssessment")
+AWCRestrictions=(AWCAbility="Suppression_LW", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="Suppression_LW", RestrictedAbility="StunGunner")
+AWCRestrictions=(AWCAbility="TraverseFire", RestrictedAbility="PointBlank")
+AWCRestrictions=(AWCAbility="TraverseFire", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="PrecisionShot", RestrictedAbility="StunGunner")
+AWCRestrictions=(AWCAbility="PrecisionShot", RestrictedAbility="KnifeFighter")
+AWCRestrictions=(AWCAbility="Flush", RestrictedAbility="FireandSteel")
+AWCRestrictions=(AWCAbility="CloseandPersonal", RestrictedAbility="KnifeFighter")
+AWCRestrictions=(AWCAbility="CloseandPersonal", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="Stealth", RestrictedAbility="ThreatAssessment")
+AWCRestrictions=(AWCAbility="Stealth", RestrictedAbility="KnifeFighter")
+AWCRestrictions=(AWCAbility="HailofBullets", RestrictedAbility="StunGunner")
+AWCRestrictions=(AWCAbility="HailofBullets", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="IronCurtain", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="IronCurtain", RestrictedAbility="StunGunner")
+AWCRestrictions=(AWCAbility="CyclicFire", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="CyclicFire", RestrictedAbility="StunGunner")
+AWCRestrictions=(AWCAbility="EverVigilant", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="Infighter", RestrictedAbility="Holotarget")

+AWCRestrictions=(AWCAbility="Cutthroat", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="Cutthroat", RestrictedAbility="StunGunner")
+AWCRestrictions=(AWCAbility="Cutthroat", RestrictedAbility="ThreatAssessment")
+AWCRestrictions=(AWCAbility="Cutthroat", RestrictedAbility="PointBlank")
+AWCRestrictions=(AWCAbility="Cutthroat", RestrictedAbility="HeavyOrdnance_LW")
+AWCRestrictions=(AWCAbility="Cutthroat", RestrictedAbility="FireandSteel")
+AWCRestrictions=(AWCAbility="Cutthroat", RestrictedAbility="FireandSteel")
+AWCRestrictions=(AWCAbility="Cutthroat", RestrictedAbility="VoidRift")
+AWCRestrictions=(AWCAbility="Blademaster", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="Blademaster", RestrictedAbility="StunGunner")
+AWCRestrictions=(AWCAbility="Blademaster", RestrictedAbility="ThreatAssessment")
+AWCRestrictions=(AWCAbility="Blademaster", RestrictedAbility="PointBlank")
+AWCRestrictions=(AWCAbility="Blademaster", RestrictedAbility="HeavyOrdnance_LW")
+AWCRestrictions=(AWCAbility="Blademaster", RestrictedAbility="FireandSteel")
+AWCRestrictions=(AWCAbility="Blademaster", RestrictedAbility="VoidRift")
+AWCRestrictions=(AWCAbility="Reaper", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="Reaper", RestrictedAbility="StunGunner")
+AWCRestrictions=(AWCAbility="Reaper", RestrictedAbility="ThreatAssessment")
+AWCRestrictions=(AWCAbility="Reaper", RestrictedAbility="PointBlank")
+AWCRestrictions=(AWCAbility="Reaper", RestrictedAbility="HeavyOrdnance_LW")
+AWCRestrictions=(AWCAbility="Reaper", RestrictedAbility="FireandSteel")
+AWCRestrictions=(AWCAbility="Reaper", RestrictedAbility="VoidRift")
+AWCRestrictions=(AWCAbility="SwordSlice_LW", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="SwordSlice_LW", RestrictedAbility="StunGunner")
+AWCRestrictions=(AWCAbility="SwordSlice_LW", RestrictedAbility="ThreatAssessment")
+AWCRestrictions=(AWCAbility="SwordSlice_LW", RestrictedAbility="PointBlank")
+AWCRestrictions=(AWCAbility="SwordSlice_LW", RestrictedAbility="HeavyOrdnance_LW")
+AWCRestrictions=(AWCAbility="SwordSlice_LW", RestrictedAbility="FireandSteel")
+AWCRestrictions=(AWCAbility="SwordSlice_LW", RestrictedAbility="VoidRift")
+AWCRestrictions=(AWCAbility="Combatives", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="Combatives", RestrictedAbility="StunGunner")
+AWCRestrictions=(AWCAbility="Combatives", RestrictedAbility="ThreatAssessment")
+AWCRestrictions=(AWCAbility="Combatives", RestrictedAbility="PointBlank")
+AWCRestrictions=(AWCAbility="Combatives", RestrictedAbility="HeavyOrdnance_LW")
+AWCRestrictions=(AWCAbility="Combatives", RestrictedAbility="FireandSteel")
+AWCRestrictions=(AWCAbility="Combatives", RestrictedAbility="VoidRift")
+AWCRestrictions=(AWCAbility="Bladestorm", RestrictedAbility="Holotarget")
+AWCRestrictions=(AWCAbility="Bladestorm", RestrictedAbility="StunGunner")
+AWCRestrictions=(AWCAbility="Bladestorm", RestrictedAbility="ThreatAssessment")
+AWCRestrictions=(AWCAbility="Bladestorm", RestrictedAbility="PointBlank")
+AWCRestrictions=(AWCAbility="Bladestorm", RestrictedAbility="HeavyOrdnance_LW")
+AWCRestrictions=(AWCAbility="Bladestorm", RestrictedAbility="FireandSteel")
+AWCRestrictions=(AWCAbility="Bladestorm", RestrictedAbility="VoidRift")

Re: AWC perk selection bugs

Posted: Wed Feb 01, 2017 11:24 am
by Sylvester
With that copy paste, I notice Sharpshooters, and I've only been re-rolling a couple classes to test, they can get Sentinel, Rapid Reaction, and Guardian all together. Is the game capable of handling that kind of perk setup?

Even more, I noticed you can get Shadowstep and Lightning Reflexes together.

Re: AWC perk selection bugs

Posted: Wed Feb 01, 2017 7:36 pm
by gftgy
What dodger posted isn't the complete list of ability restrictions, just a conversion of the class restrictions. Below that lines 258 and 259 read
+AWCRestrictions=(AWCAbility="LightningReflexes_LW", RestrictedAbility="Shadowstep")
+AWCRestrictions=(AWCAbility="Shadowstep", RestrictedAbility="LightningReflexes_LW")
Which should prevent you from getting both lightning reflexes and shadowstep. The lines below 255 do not need to be changed.

I've added dodger's code to the OP.

Re: AWC perk selection bugs

Posted: Sat Feb 04, 2017 9:22 am
by RXTXK
Am I right in thinking that the perks get assigned on character creation (rather than AWC level up) therefore the fix above won't impact existing characters?
Does that also apply to recruits before they become rookies? (i.e. a solider in the recruit screen has and already rolled AWC tree?)

Re: AWC perk selection bugs

Posted: Sat Feb 04, 2017 10:13 am
by Thrair
AWC perks are assigned upon promotion to Squaddie, not upon creation. You can confirm this by either having the AWC built (or revealing AWC perks with an ini edit) and having a rookie ready to promote. They'll get different abilities each time, even if they roll up the same class.

Re: AWC perk selection bugs

Posted: Sat Feb 04, 2017 11:57 am
by cerebrawl
Yeah, squaddie upgrade sets AWC perks, this is permanent and there's no console command to fix it except one which rerolls the AWC tree for ALL of your soldiers. If it's a character pool soldier you really want but got bad AWC allocations on, you can dismiss them and they will return to the recruit list or as a reward later, with a clean slate.

Re: AWC perk selection bugs

Posted: Sat Feb 04, 2017 6:45 pm
by moroniccinamun
Hi, pardon my noobishness but I know nothing about editing .ini files.

So I used the tl;dr version. I don't have line numbers or even coherent lines in note pad, it text wraps based on the size of the window.

Does the ;;;restrict;;; end at the ;;;image;;; section? that's what it looks like to me, just want to make sure before I break everything and have to start a new game (not that I would complain that much, as I won't have like any of the correct awc unless I go out of my way to get more rookies :lol: )

Re: AWC perk selection bugs

Posted: Sat Feb 04, 2017 8:54 pm
by Amineri
Thrair wrote:AWC perks are assigned upon promotion to Squaddie, not upon creation. You can confirm this by either having the AWC built (or revealing AWC perks with an ini edit) and having a rookie ready to promote. They'll get different abilities each time, even if they roll up the same class.
This is a requirement due to the fact that class abilities aren't set until the unit is promoted to squaddie and a class is picked. At that point, the AWC ability randomizer can then go in and select (and permanently store) a set of AWC abilities that won't duplicate any of the class abilities. Of course a mod like Commander's Choice can possibly break this.

Re: AWC perk selection bugs

Posted: Sat Feb 04, 2017 8:57 pm
by Amineri
moroniccinamun wrote:Hi, pardon my noobishness but I know nothing about editing .ini files.

So I used the tl;dr version. I don't have line numbers or even coherent lines in note pad, it text wraps based on the size of the window.

Does the ;;;restrict;;; end at the ;;;image;;; section? that's what it looks like to me, just want to make sure before I break everything and have to start a new game (not that I would complain that much, as I won't have like any of the correct awc unless I go out of my way to get more rookies :lol: )
Because of some quirks in our version control system, most of our files use unix-style line-endings (/LF). The basic Notepad app doesn't recognize these as valid line-endings, so everything looks like a single line -- it only recognizes windows-style line-endings (/CR/LF). I avoid using notepad at all, and instead I use Notepad++.

Re: AWC perk selection bugs

Posted: Sat Feb 04, 2017 9:42 pm
by moroniccinamun
Amineri wrote:
moroniccinamun wrote:Hi, pardon my noobishness but I know nothing about editing .ini files.

So I used the tl;dr version. I don't have line numbers or even coherent lines in note pad, it text wraps based on the size of the window.

Does the ;;;restrict;;; end at the ;;;image;;; section? that's what it looks like to me, just want to make sure before I break everything and have to start a new game (not that I would complain that much, as I won't have like any of the correct awc unless I go out of my way to get more rookies :lol: )
Because of some quirks in our version control system, most of our files use unix-style line-endings (/LF). The basic Notepad app doesn't recognize these as valid line-endings, so everything looks like a single line -- it only recognizes windows-style line-endings (/CR/LF). I avoid using notepad at all, and instead I use Notepad++.

Thanks! Worked wonders (as far as editing went). Now to test it.